Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Add whitespace rule for ExportDeclaration #4554

Merged
merged 1 commit into from
Mar 2, 2019
Merged

Add whitespace rule for ExportDeclaration #4554

merged 1 commit into from
Mar 2, 2019

Conversation

devmattrick
Copy link
Contributor

@devmattrick devmattrick commented Feb 28, 2019 •
edited by JoshuaKGoldberg
Loading

PR checklist

Overview of change:

Adds a case to handle ExportDeclaration, to properly lint and fix statements such as:

export { A, B };

CHANGELOG.md entry:

[bugfix] Lint export statements with whitespace rule

@devmattrick devmattrick changed the title Add whitespace rule for ExportDeclaration (fixes #4014) Add whitespace rule for ExportDeclaration Feb 28, 2019
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Mar 2, 2019
View reviewed changes
Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

Although TSLint is moving away from whitespace rules, the presense of an auto-fixer and the issue already having been marked as Status: Accepting PRs makes this seem reasonable.

@JoshuaKGoldberg JoshuaKGoldberg merged commit e72d553 into palantir:master Mar 2, 2019
@adidahiya adidahiya mentioned this pull request Mar 13, 2019
Merged
@snyk-bot snyk-bot mentioned this pull request Oct 11, 2019
Merged
@snyk-bot snyk-bot mentioned this pull request Oct 26, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Nov 15, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Dec 15, 2019
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing whitespace around export statement with "check-module" argument
2 participants
@devmattrick @JoshuaKGoldberg